fix: improved support for CIDv1 and subdomain gateways #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue described in ensdomains/ui#46 (comment)
lidel
changed the title
lidel
force-pushed
the
fix/support-cidv1-input
branch
from
f8c7ffc
to
5172c1b
Compare
This helper returns DNS-based-web-safe encoding that fits in a single DNS label. I also updated CID-related dependencies
lidel
force-pushed
the
fix/support-cidv1-input
branch
from
5172c1b
to
3914183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pldespaigne this fixes the bug described in ensdomains/ui#46 (comment) and updates IPFS-side of things, so you avoid problems going forward.
I also added
cidForWebhelper which returns DNS-based-web-safe encoding that fits in a single DNS label.