Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace generate with embed #137

Closed
jimafisk opened this issue Feb 6, 2021 · 1 comment
Closed

Replace generate with embed #137

jimafisk opened this issue Feb 6, 2021 · 1 comment
Labels
refactor optimize or improve existing code / functionality

Comments

@jimafisk
Copy link
Member

jimafisk commented Feb 6, 2021

I had been watching golang/go#41191 early on to see if we could use embed instead of generate. @zaydek pointed out to me that this has been pulled into go1.16. He sent an example implementation: https://github.com/zaydek/retro/blob/master/go/cmd/create-retro-app/embeds/embeds.go

@jimafisk jimafisk added the refactor optimize or improve existing code / functionality label Feb 6, 2021
jimafisk added a commit that referenced this issue Mar 1, 2021
@jimafisk
Copy link
Member Author

jimafisk commented Apr 1, 2021

Generate has been removed and embed is used in v0.4.0+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor optimize or improve existing code / functionality
Projects
None yet
Development

No branches or pull requests

1 participant