Change client limits #532
Open
Change client limits #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts-shopware-connector * 'master' of https://github.com/plentymarkets/plentymarkets-shopware-connector: tax handling refactored (plentymarkets#500) fix sorting of product images (plentymarkets#499) tax handling refactored (plentymarkets#498)
…ts-shopware-connector * 'master' of https://github.com/plentymarkets/plentymarkets-shopware-connector: surcharge tax fix (plentymarkets#507) getCustomerGroupIdentity() typehint remove (plentymarkets#506) Tax fix (plentymarkets#505) throw rest response on error (plentymarkets#504) 5.2.1 (plentymarkets#503) remove item variation id at vouchers and discounts (plentymarkets#502) fix empty invoiceShippingTaxRate (plentymarkets#501)
…ts-shopware-connector * 'master' of https://github.com/plentymarkets/plentymarkets-shopware-connector: Fix item import (plentymarkets#511) Fix error tax handling (plentymarkets#509) #fix wrong float cast (plentymarkets#510)
…ts-shopware-connector * 'master' of https://github.com/plentymarkets/plentymarkets-shopware-connector: skip not existing articles in order response parser (plentymarkets#530) fixed client for put calls (plentymarkets#529) set shipping time on multi package order (plentymarkets#527) null check on customer gender (plentymarkets#528) add manufacturer external name as attribute (plentymarkets#526) 5.3.3 (plentymarkets#524) add system currency to config (plentymarkets#522) amazon Pay Fix (plentymarkets#521) add manufacturer external name as attribute (plentymarkets#519) add manufacturer attributes (plentymarkets#518) limit (plentymarkets#517) 5.3.1 (plentymarkets#516) travis (plentymarkets#514) 5.6 (plentymarkets#513)
…lient-limits * commit '887a6d21822992495b014bb28267f627333c8417': csfixer skip not existing order item round orderItem amount
* fix-cs: fix cs
jochenmanz
reviewed
Mar 14, 2020
| @@ -417,6 +434,10 @@ private function handleRequestException(Throwable $exception, $method, $path, ar | |||
| private function prepareResponse($limit, $offset, array $options, array $response): array | |||
| { | |||
| if (!isset($options['plainResponse']) || !$options['plainResponse']) { | |||
| if (isset($response['itemsPerPage']) && $response['itemsPerPage'] !== $this->itemsPerPage) { | |||
There was a problem hiding this comment.
Gute Idee mit dem Fallback! :) Es gab einige Routen die ein kleineres itemsPerPage hatten, das fängt diese ja ab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR change the default api limit from 50 to 200.
Checklist