major(deps): Upgrade to Guice v7 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinw
commented
Jan 29, 2024
|
Hey @jsfr do you recall how we are supposed to version and release Prop? |
Not really. But looking at the workflows it looks like it's using |
This reverts commit a5c16f8.
# Conflicts: # prop-all/src/test/kotlin/io/pleo/prop/objects/BothNamedAnnotations.kt
erwinw
force-pushed
the
chore/bump-juice-v7
branch
from
c9bade1
to
60e4783
Compare
andriygg
approved these changes
Jan 31, 2024
| @@ -20,7 +20,8 @@ import java.lang.reflect.ParameterizedType | |||
| import java.lang.reflect.Type | |||
| import java.util.Optional.ofNullable | |||
| import java.util.function.Predicate | |||
| import javax.inject.Named | |||
| import com.google.inject.name.Named as JuiceNamed | |||
There was a problem hiding this comment.
small alias naming inconsistency, in another place it was GoogleNamed
jsfr
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Guice v7
BREAKING CHANGE: This drops support for
javax.injectin favor ofjakarta.inject.com.google.injectis still supported.