Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/getDevices: fix filling doxm values for owned devices #249

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Apr 12, 2022

No description provided.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

69.6% 69.6% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #249 (863c4e9) into main (40d40de) will decrease coverage by 0.45%.
The diff coverage is 52.32%.

@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   61.08%   60.62%   -0.46%     
==========================================
  Files          63       63              
  Lines        3888     3980      +92     
==========================================
+ Hits         2375     2413      +38     
- Misses       1199     1232      +33     
- Partials      314      335      +21     
Impacted Files Coverage Δ
client/core/discover.go 77.77% <ø> (ø)
client/core/getOwnership.go 81.81% <0.00%> (ø)
client/deviceOwnershipBackend.go 0.00% <0.00%> (ø)
schema/acl/acl.go 0.00% <ø> (ø)
schema/credential/credential.go 0.00% <ø> (ø)
pkg/net/coap/client.go 56.57% <16.12%> (+3.96%) ⬆️
client/options.go 48.36% <33.33%> (-2.51%) ⬇️
client/core/disownDevice.go 75.75% <37.50%> (+0.75%) ⬆️
client/core/device.go 64.56% <40.00%> (-3.15%) ⬇️
client/core/ownDevice.go 57.87% <41.11%> (-5.23%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b602774...863c4e9. Read the comment docs.

@jkralik jkralik merged commit 024b8ed into main Apr 12, 2022
@jkralik jkralik deleted the jkralik/fix/getDevicesForOwnedDevices branch April 12, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants