Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement delete devices #299

Merged
merged 2 commits into from
Oct 12, 2022
Merged

implement delete devices #299

merged 2 commits into from
Oct 12, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Oct 12, 2022

No description provided.

@jkralik jkralik requested a review from lubo-svk October 12, 2022 13:19
@jkralik jkralik changed the title Jkralik/feature/delete devices implement delete devices Oct 12, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.3% 76.3% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #299 (aed4b79) into main (d8082b9) will increase coverage by 0.02%.
The diff coverage is 72.09%.

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   62.85%   62.88%   +0.02%     
==========================================
  Files          65       65              
  Lines        3995     4017      +22     
==========================================
+ Hits         2511     2526      +15     
- Misses       1133     1138       +5     
- Partials      351      353       +2     
Impacted Files Coverage Δ
client/getDevice.go 71.11% <0.00%> (ø)
client/getDevices.go 67.97% <0.00%> (ø)
client/client.go 62.83% <50.00%> (-0.81%) ⬇️
client/ownDevice.go 42.85% <66.66%> (ø)
client/deviceCache.go 81.51% <73.68%> (-2.45%) ⬇️
client/deleteDevices.go 85.71% <85.71%> (ø)
client/disownDevice.go 69.23% <100.00%> (ø)
client/core/client.go 83.56% <0.00%> (-4.11%) ⬇️
client/core/maintenance.go 70.37% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

client/deviceCache.go Show resolved Hide resolved
@jkralik jkralik merged commit 3659670 into main Oct 12, 2022
@jkralik jkralik deleted the jkralik/feature/deleteDevices branch October 12, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants