-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement m2m-token for Trigger Command Execution via m2m-oauth-server #1336
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 22 files out of 79 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
f94e6f8
to
e7b4f68
Compare
{{- end }} | ||
labels: | ||
{{- include "plgd-hub.m2moauthserver.selectorLabels" . | nindent 8 }} | ||
spec: |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods
- mountPath: /keys | ||
name: keys | ||
containers: | ||
- name: {{ .Values.m2moauthserver.name }} |
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
8a9a33a
to
311ed7a
Compare
This depends on the cluster where the hub is running. In production, each user needs to set up their own cluster. If we set the limits too low, the processes will be killed by OOM (Out of Memory) errors. |
dbb8c6a
to
b0a5dd4
Compare
8b834f2
to
ce697ce
Compare
@coderabbitai review |
Actions performedReview triggered.
|
@coderabbitai summary |
Actions performedSummary regeneration triggered. |
cloud2cloud-gateway/service/retrieveAllDevicesSubscription_test.go
Outdated
Show resolved
Hide resolved
2d933f6
to
a8f37c0
Compare
c863239
to
0844c3b
Compare
@coderabbitai summary |
Actions performedSummary regeneration triggered. |
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 22 files out of 79 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai create summary over files under m2m-oauth-server directory and helm chart |
Tip For best results, initiate chat on the files or code changes. @jkralik, here is the summary of the changes:
|
@coderabbitai create summary over all files under m2m-oauth-server and charts directories |
Tip For best results, initiate chat on the files or code changes. @jkralik, here is the updated summary of the changes:
|
@coderabbitai create a description for whole pull request based on |
Tip For best results, initiate chat on the files or code changes. @jkralik, here is the comprehensive description of the pull request based on changes in the Pull Request DescriptionObjectiveThe primary objective of this pull request is to allow configuring multiple authorities for m2m-token. Changes in
|
Quality Gate passedIssues Measures |
Description
This PR introduces the
m2m-token
functionality, enabling the execution of trigger commands from various services. Them2m-token
is issued by them2m-oauth-server
through the credential flow.To obtain the token, users can utilize a secret or another JWT token signed by an authority configured within the
m2m-oauth-server
.Key highlights of this implementation include:
m2m-oauth-server
for token issuance.