Skip to content
This repository has been archived by the owner on Aug 13, 2020. It is now read-only.

Norwegian translation #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Norwegian translation #30

wants to merge 1 commit into from

Conversation

erikbra
Copy link

@erikbra erikbra commented Feb 4, 2016

Norwegian translation, based on English and Danish translation.

@CLAassistant
Copy link

CLA assistant check
All committers have accepted the CLA.

@erikbra
Copy link
Author

erikbra commented Feb 4, 2016

@ploeh, I tried signing the CLA, but it doesn't seem to have kicked in. Do I need to do anything other than accepting it?

@ploeh
Copy link
Owner

ploeh commented Feb 10, 2016

Thank you for your interest in contributing to Numsense 👍

I had to dig a little in order to figure out why the CLA status is unsigned, but I think I've figured it out. The commit in this pull request was authored by erikbran, whom, I believe, is you, but not the same identity as @erikbra. I think you need to sign the CLA as erikbran, or alternatively update the commit author to be @erikbra.

@erikbra
Copy link
Author

erikbra commented Feb 16, 2016

Sorry for that. I have multiple git identities, one for work related, one for private. I had forgotten to update the user.name in the git config. I have now updated the commit author, and rebased the latest changes from master. the CLA check looks good now.

//[<InlineData("tomilliardertjuenimillionertohunderogsekstitusen", 2029260000)>]
//[<InlineData(
// "tomilliarderetthundreogførtisjumillionerfirehundreogåttitretusensekshundreogførtisju",
// System.Int32.MaxValue)>]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are so many of these examples commented out?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that was just a mishap. I'll look into it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants