-
Notifications
You must be signed in to change notification settings - Fork 34
Added italian language support. #36
base: master
Are you sure you want to change the base?
Conversation
Numsense/Italian.fs
Outdated
@@ -0,0 +1,121 @@ | |||
module Ploeh.Numsense.Italian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this export the Ploeh.Numsense.Italian
module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I forgot the "internal" keyword inside my keyboard... ;-)
Thank you for your interest in contributing to Numsense. Thus pull request looks promising 👍 |
It builds and runs all tests without warnings on my machine, so from a technical perspective I think we're good to go 👍 As I don't read Italian, I'd like someone who does to review that part of it, if at all possible. I don't expect any errors, but it's always good with a second pair of eyes 😄 |
I solicited a review on Twitter: https://twitter.com/ploeh/status/702383554689417220 Please retweet and spread the word 😄 |
Couldn't spot any mistake in the unit tests. Bravo! |
sorry to be pedantic but I found two little issues due to nuances of the Italian grammar:
cheers, |
Hi @giacomociti |
HI @albertodall , in fact I think the link you provided is enough to dismantle my second objection :) Ciao |
…nta" and "centoottanta" should be both parsed as 180. Added specific tests.
Since centoottanta and centottanta are both correct, Numsense now parses both as 180. |
According to Treccani, ventitré needs to be accented (that and any other number ending with "tré", except "tre" itself, which is a monosyllable). Source: http://www.treccani.it/enciclopedia/accento_(La_grammatica_italiana)/ |
… on "tre" itself). Moved tens handling from "simplify" to the "toItalianImp" function body. Added unit tests
I should have handled the accent on "tre" if found at the end of other numbers. |
Merge remote-tracking branch 'refs/remotes/ploeh/master'
I added the italian language support.