-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update javascript image to include java to support selenium #97
Conversation
I gotta say I love the emojis in the step names 🎉👍👻 |
is it a github workflow if it doesn't have emojoies in it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kharyam can you add the note to https://github.com/ploigos/ploigos-containers/blob/main/ploigos-tool-javascript/README.md
@kharyam bumping this. Also can you update the commit message to include "... to support selenium testing" or something to that affect?
9f89ac1
to
bc75473
Compare
Updated, thanks! |
@kharyam if you didnt see, looks like some build error for the maven images. but i didn't think you touched those....maybe something broke outside of your PR? |
bc75473
to
731a7cf
Compare
@kharyam seems like we should do the maven version change in a seperate PR, or at least make it a seperate commit. seems to not be "the fault of this change" but just an issue blocking you. sorry for the pain. |
Heyo @kharyam sory to be a pain, but can you seperate the maven change into its own commit, can leave it in this PR for simplicity if you want, but at least having a clear history of when we bumped maven version would be good. |
731a7cf
to
23810a2
Compare
@itewk no problem - done |
@kharyam thanks |
Purpose
Currently, the javascript container image does not contain the java executable. There are cases where java is required, most notably when running UAT tests via selenium.
Breaking?
No
Integration Testing