Update content filtering options for TinyMCE #4060
Conversation
|
@petschki thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
To demonstrate the impact: Before: 343.143 Bytes 😳 |
| for tag in nasty_tags: | ||
| tag_str = "{}[{}]".format(tag, "|".join(valid_attributes)) | ||
| tiny_valid_elements.append(tag_str) | ||
| tiny_config["valid_elements"] = ",".join(tiny_valid_elements) |
There was a problem hiding this comment.
Are you sure we don't need this anymore?
We need to make sure, that what ever is set in the HTML filter control panal is not in conflict with what TinyMCE filtering does. Is that's the case I'm fine with the simplification.
There was a problem hiding this comment.
You're right. Only relying on the "html5" schema doesn't fit our safe_html transformation. I've updated this to fix our test scenarios again.
|
@jenkins-plone-org please run jobs |
1 similar comment
|
@jenkins-plone-org please run jobs |
fixes #3204
This reduces the loaded page size for forms with tinymce
(tested with
curl --user admin:admin -so /dev/null http://localhost:8080/Plone/edit -w "%{size_download}")Before: 128.620 Bytes
After: 75.674 Bytes