fix: Fixed a bug where some nodes could be skipped after converting a…

…n element to a block. (#42)
plone · Nov 20, 2023 · 03f7b20 · 03f7b20
1 parent 9369b46
commit 03f7b20
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/src/converters/fromHtml.js b/src/converters/fromHtml.js
@@ -97,7 +97,7 @@ const extractElementsWithConverters = (el, defaultTextBlock, href) => {
     href = el.getAttribute('href');
   }
   // First, traverse all childNodes
-  for (const child of el.childNodes) {
+  for (const child of Array.from(el.childNodes)) {
     const tmpResult = extractElementsWithConverters(
       child,
       defaultTextBlock,
@@ -146,7 +146,7 @@ const convertFromHTML = (input, defaultTextBlock) => {
 
   // convert to blocks
   for (const el of elements) {
-    const children = el.childNodes;
+    const children = Array.from(el.childNodes);
     const href = el.getAttribute('href');
     for (const child of children) {
       // With children nodes, we keep the wrapper only

diff --git a/src/converters/fromHtml.test.js b/src/converters/fromHtml.test.js
@@ -350,6 +350,30 @@ describe('convertFromHTML parsing image', () => {
     ]);
   });
 
+  test('inside a block element with another image', () => {
+    const html = '<div><img src="image1.jpg"><img src="image2.jpg"></div>';
+
+    const result = convertFromHTML(html, 'slate');
+    expect(result).toEqual([
+      {
+        '@type': 'image',
+        align: 'center',
+        alt: '',
+        size: 'l',
+        title: '',
+        url: 'image1.jpg',
+      },
+      {
+        '@type': 'image',
+        align: 'center',
+        alt: '',
+        size: 'l',
+        title: '',
+        url: 'image2.jpg',
+      },
+    ]);
+  });
+
   test('inside a p element', () => {
     const html = '<p><img src="image.jpeg"></p>';