Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update robotframework-browser version (and dependencies) #954

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Update robotframework-browser version (and dependencies) #954

merged 4 commits into from
Oct 17, 2024

Conversation

petschki
Copy link
Member

@petschki petschki commented Oct 7, 2024

Due to the progress here plone/Products.CMFPlone#4019 we need up to date versions ...

@petschki petschki mentioned this pull request Oct 7, 2024
Merged
27 tasks
@wesleybl
Copy link
Member

wesleybl commented Oct 9, 2024

@jenkins-plone-org please run jobs

@mauritsvanrees mauritsvanrees mentioned this pull request Oct 11, 2024
Closed
6 tasks
@petschki
Copy link
Member Author

The tests are flaky even after backporting the versions to rfbrowser <18 ... I'd suggest to bring the latest versions to coredev 6.1 and get the ported tests done here plone/Products.CMFPlone#4019

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki petschki marked this pull request as ready for review October 13, 2024 22:40
@petschki
Copy link
Member Author

@gforcada the updated rfbrowser 18.8.1 doesn't work with the current node version ... on Node 4 it says:

2024-10-13 15:42:19,657 [INFO    ] npm WARN EBADENGINE   package: '@eslint/config-array@0.18.0',
2024-10-13 15:42:19,657 [INFO    ] npm WARN EBADENGINE   required: { node: '^18.18.0 || ^20.9.0 || >=21.1.0' },
2024-10-13 15:42:19,657 [INFO    ] npm WARN EBADENGINE   current: { node: 'v20.5.1', npm: '9.8.0' }
2024-10-13 15:42:19,657 [INFO    ] npm WARN EBADENGINE }

https://jenkins.plone.org/job/pull-request-6.1-3.12/740/console

@petschki petschki changed the title Update robotframework-browser version (and dependecies) Update robotframework-browser version (and dependencies) Oct 14, 2024
@petschki petschki merged commit f86512f into 6.1 Oct 17, 2024
12 of 14 checks passed
@petschki petschki deleted the robotframework-browser-versionupdates branch October 17, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees Awaiting requested review from mauritsvanrees

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petschki @wesleybl