Playwright tests #176
Merged
Playwright tests #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforcada
force-pushed
the
playwright-tests
branch
from
2a98e1e
to
e1b0c90
Compare
This was referenced Oct 7, 2023
gforcada
force-pushed
the
playwright-tests
branch
from
e1b0c90
to
fe3239e
Compare
But only do it when the package being configured is actually using robotframework otherwise is both useless and it will break, as the binary to download the browsers will not be there.
gforcada
force-pushed
the
playwright-tests
branch
from
fe3239e
to
d0982a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155
Rather than a setting that needs to be set up on
.meta.tomlwe try to detect if the package needs it.Hopefully the package uses the dependency checker tool, and thus, the dependency on
plone.app.robotframeworkcan be easily spotted ✨