Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schemaeditor #1203

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Fix schemaeditor #1203

merged 2 commits into from
Aug 3, 2022

Conversation

frapell
Copy link
Member

@frapell frapell commented Jul 27, 2022

Fix adding fields to fieldsets, and drag and drops between fieldsets.

Prevent adding fields to fieldsets from behaviors.

fixes gh-1201

…rops between fieldsets. Prevent adding fields to fieldsets from behaviors. fixes gh-1201
@frapell
Copy link
Member Author

frapell commented Jul 27, 2022

This needs plone/plone.schemaeditor#92

@frapell
Copy link
Member Author

frapell commented Jul 27, 2022

@petschki @thet You guys want to give it a try?

Btw, I am preventing adding and drag&drop fields to fieldsets added from behaviors, since I don't think that was ever intended... At least I am not finding a proper way to do it...

You will need to use the mentioned branch from plone/plone.schemaeditor#92

@frapell frapell requested a review from petschki July 28, 2022 11:51
@frapell
Copy link
Member Author

frapell commented Jul 28, 2022

@thet Do I need to do anything to the changelog? I was under the impression that it was automatically generated out of the commits when they include parts like fix(pat schemaeditor) right?

@petschki
Copy link
Member

petschki commented Jul 28, 2022

Nothing to do in changelog since your commit message fits the release-it conventional changelog ...

I suggest to do the following:
Create a PR in plone.staticresources with the latest commit hash here as mockup dependency in package.json and Test it together with the schemaeditor PR in Jenkins.

Don't forget to run make all in staticresources when changing dependencies.

frapell added a commit to plone/plone.staticresources that referenced this pull request Jul 28, 2022
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petschki petschki merged commit d3a62cd into master Aug 3, 2022
@petschki petschki deleted the frapell-schemaeditor branch August 3, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schemaeditor breaks with fieldsets
2 participants