Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide an IContentListingObject adapter #411

Merged
merged 7 commits into from
Nov 19, 2024
Merged

provide an IContentListingObject adapter #411

merged 7 commits into from
Nov 19, 2024

Conversation

erral
Copy link
Member

@erral erral commented Sep 12, 2024

No description provided.

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erral Could you take a look at the failing tests, and add a new test which shows getting some values from the occurrence adapter?

@erral
Copy link
Member Author

erral commented Oct 10, 2024

@jenkins-plone-org please run jobs

plone/app/event/adapters.py Outdated Show resolved Hide resolved
erral and others added 2 commits November 11, 2024 08:14
@erral
Copy link
Member Author

erral commented Nov 12, 2024

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit b816b2a into master Nov 19, 2024
14 checks passed
@davisagli davisagli deleted the erral-issue-410 branch November 19, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants