fix interface of settings according to CMFPlone #394
Conversation
|
@jensens thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
jensens
force-pushed
the
fix-registry-record
branch
from
59e9e42 to
00b025f
Compare
|
@jenkins-plone-org please run jobs |
1 similar comment
|
@jenkins-plone-org please run jobs |
|
There is a failure in repoze.xmliter which is probably complete unrelated. |
|
No, have not seen it. Looks like only a few extra newlines. |
|
|
|
On my coredev 6 checkout, I was on commit 4d5637fe9c86bcfedd6ca41382425539407bfca4 and ran |
This should fix the broken build, as the `repoze.xmliter` tests were failing due to some extra newline characters. See discussion at plone/plone.app.multilingual#394 We extend the versions.cfg from Zope master, which has upgraded lxml to 4.7.1. (4.7.0 was yanked, probably some failed/broken release.) It could be one of its bugfixes, or this new feature: Chunked Unicode string parsing via parser.feed() now encodes the input data to the native UTF-8 encoding directly, instead of going through Py_UNICODE / wchar_t encoding first, which previously required duplicate recoding in most cases.
|
Found it. Fixed by pinning older @jenkins-plone-org please run jobs |
In CMFPlone this was moved to plone.i18n and is referenced as such there, here the change was missing.