Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pat contentbrowser #470

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Conversation

1letter
Copy link
Contributor

@1letter 1letter commented Oct 21, 2024

No description provided.

@mister-roboto
Copy link

@1letter thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@1letter 1letter linked an issue Oct 21, 2024 that may be closed by this pull request
@1letter
Copy link
Contributor Author

1letter commented Oct 21, 2024

@jenkins-plone-org please run jobs

@1letter 1letter self-assigned this Oct 21, 2024
@1letter 1letter marked this pull request as draft October 21, 2024 20:43
@1letter
Copy link
Contributor Author

1letter commented Oct 22, 2024

the test will fail until plone.app.z3cform > 4.6 is not in in https://dist.plone.org/release/6.1-dev/constraints.txt

@1letter 1letter force-pushed the implement-pat-contentbrowser branch from a879cc7 to b85dac4 Compare November 7, 2024 11:25
@1letter 1letter marked this pull request as ready for review November 7, 2024 11:44
@1letter 1letter requested a review from petschki November 7, 2024 12:52
@1letter
Copy link
Contributor Author

1letter commented Nov 7, 2024

these changes are requires a new release plone.app.multilingual 8.2.x for Plone 6.1.

@petschki
Copy link
Member

petschki commented Nov 7, 2024

OK, so there should be a new 8.1.x release and afterwards an 8.1.x maintenance branch, so that we can merge this into master then. I'd say #468 also targets the new 8.2.x version then ... what do you think @erral ?

@erral
Copy link
Member

erral commented Nov 7, 2024

Yes, I agree. Both PRs should go to a new .x version

@petschki
Copy link
Member

petschki commented Nov 7, 2024

8.1.4 released and 8.1.x branch created ... I'll merge this one

@petschki petschki merged commit a173ada into master Nov 7, 2024
13 checks passed
@petschki petschki deleted the implement-pat-contentbrowser branch November 7, 2024 14:22
@petschki
Copy link
Member

petschki commented Nov 7, 2024

Note: I saw that Plone 6.0 is already pined to 7.x so 8.1.x is already Plone 6.1 only. But for semantic versioning reasons 8.2.0 makes sense of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement pat-contentbrowser pattern in the connection translation form
4 participants