Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative query support: string.isNot and selection.none #110

Merged
merged 1 commit into from
May 24, 2022

Conversation

thet
Copy link
Member

@thet thet commented May 23, 2022

Add negation-query operators string.isNot and selection.none.
New plone.app.querystring.operation.string.isNot and plone.app.querystring.operation.selection.none including upgrade steps.

@mister-roboto
Copy link

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@thet thet marked this pull request as draft May 23, 2022 20:55
@thet thet requested a review from jensens May 23, 2022 20:55
@thet thet force-pushed the thet-excludes branch 2 times, most recently from 3ec5d85 to 28b82ed Compare May 23, 2022 22:48
@thet
Copy link
Member Author

thet commented May 23, 2022

@jenkins-plone-org please run jobs

@thet thet marked this pull request as ready for review May 23, 2022 22:48
New ``plone.app.querystring.operation.string.isNot`` and ``plone.app.querystring.operation.selection.none`` including upgrade steps.
@thet
Copy link
Member Author

thet commented May 24, 2022

@jenkins-plone-org please run jobs

@thet thet changed the title Add new query operator _excludes, used in string.isNot and selection.none. Add negative query support: string.isNot and selection.none May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants