Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add behavior IVersionable to Portal #87

Closed
wants to merge 2 commits into from
Closed

Conversation

wesleybl
Copy link
Member

@wesleybl wesleybl commented Oct 3, 2024

This is part of: plone/volto#5284

In order for the working copy of plone.app.iterate to work in the Portal, it needs to be versionable and have the IVersionable behavior. See:

https://github.com/plone/plone.app.iterate/blob/1908aa1f4e9c95c37143fae88655469b72ea451a/plone/app/iterate/browser/control.py#L50-L52

In order for the working copy of `plone.app.iterate` to work in the
Portal, it needs to be versionable and have the IVersionable behavior.
See:

https://github.com/plone/plone.app.iterate/blob/1908aa1f4e9c95c37143fae88655469b72ea451a/plone/app/iterate/browser/control.py#L50-L52
@mister-roboto
Copy link

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@wesleybl
Copy link
Member Author

wesleybl commented Oct 3, 2024

@jenkins-plone-org please run jobs

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I don't like about this, is that we would then have two behaviors: plone.versioning and plone.versioning.portal. This is visible in the Isn't there some interface that is shared between the Plone Site root and normal Dexterity content?

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleybl Like Maurits, I don't understand why a new behavior is needed. Can't we just enable the existing behavior for the Plone Site content type? The portal object should have the IDexterityContent interface starting in Plone 6.0.

@wesleybl
Copy link
Member Author

The portal object should have the IDexterityContent interface starting in Plone 6.0

@mauritsvanrees @davisagli this is true when you create a Classic Plone Site. But when you create a modern Plone Site, something happens and it stops working. This may require further investigation.

@wesleybl
Copy link
Member Author

wesleybl commented Nov 4, 2024

@mauritsvanrees @davisagli I did a test here and there really is no need for new behavior.

@wesleybl wesleybl closed this Nov 4, 2024
@wesleybl wesleybl deleted the working_copy_portal branch November 4, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants