Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank launch screen in Chrome #102

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix blank launch screen in Chrome #102

merged 1 commit into from
Nov 13, 2024

Conversation

davisagli
Copy link
Member

Fixes #101

@ericof ericof merged commit 7c71325 into main Nov 13, 2024
6 checks passed
@ericof ericof deleted the fix-app-load branch November 13, 2024 22:12
@rohnsha0
Copy link

Thanks @davisagli 😉

@1letter 1letter linked an issue Nov 18, 2024 that may be closed by this pull request
@stevepiercy
Copy link
Contributor

Did this also fix #100? It's still open but it is linked to this PR.

@rohnsha0
Copy link

it should be fixed as the issue seems similar

@rohnsha0
Copy link

but will need to be tested tho

@JeffersonBledsoe
Copy link
Member

I'm going to assume this also the same problem found in #94 and will close that issue :)

@rohnsha0 rohnsha0 linked an issue Nov 20, 2024 that may be closed by this pull request
@rohnsha0
Copy link

rohnsha0 commented Nov 20, 2024

@davisagli can you please confirm if I try to reproduce the same using buildout.coredev then should that be fixed as of now? or will it be fixed after new version release of this repo?

@davisagli
Copy link
Member Author

@rohnsha0 I just added plone.distribution to the list of checkouts for buildout.coredev (plone/buildout.coredev@d403945) so now it should work there (if you rebuild) even before a release.

@gforcada How do we make sure that mr.roboto will add plone.distribution to the list of checkouts in buildout.coredev if there are new changes? This isn't working yet for this new package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants