extractCredentials: do not fail when the request is too large to read.

See plone/Products.CMFPlone#3848 and zopefoundation/Zope#1180.
plone · Oct 31, 2023 · 3a3770b · 3a3770b
1 parent c43fd4f
commit 3a3770b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/news/3848.bugfix b/news/3848.bugfix
@@ -0,0 +1,2 @@
+``extractCredentials``: do not fail when the request is too large to read.
+@maurits
diff --git a/src/plone/restapi/pas/plugin.py b/src/plone/restapi/pas/plugin.py
@@ -14,6 +14,7 @@
 from Products.PluggableAuthService.interfaces.plugins import IChallengePlugin
 from Products.PluggableAuthService.interfaces.plugins import IExtractionPlugin
 from Products.PluggableAuthService.plugins.BasePlugin import BasePlugin
+from zExceptions import BadRequest
 from zope.component import getUtility
 from zope.interface import implementer
 
@@ -98,6 +99,8 @@ def extractCredentials(self, request):
         # is intended to change or update the logged in user.
         try:
             creds = deserializer.json_body(request)
+        except BadRequest:
+            pass
         except exceptions.DeserializationError:
             pass
         else:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		``extractCredentials``: do not fail when the request is too large to read.
		@maurits