Choose valid id if id is provided for content creation

plone · Mar 31, 2023 · 696edbc · 696edbc
1 parent b15ddc0
commit 696edbc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/news/1613.bugfix b/news/1613.bugfix
@@ -0,0 +1,2 @@
+Choose valid id if id is provided for content creation.
+@ksuess
diff --git a/src/plone/restapi/services/content/utils.py b/src/plone/restapi/services/content/utils.py
@@ -81,8 +81,8 @@ def add(container, obj, rename=True):
             obj._renameAfterCreation(check_auto_id=True)
         return obj
     else:
+        chooser = INameChooser(container)
         if rename:
-            chooser = INameChooser(container)
             # INameFromTitle adaptable objects should not get a name
             # suggestion. NameChooser would prefer the given name instead of
             # the one provided by the INameFromTitle adapter.
@@ -91,7 +91,9 @@ def add(container, obj, rename=True):
             if name_from_title is None:
                 suggestion = obj.Title()
             id_ = chooser.chooseName(suggestion, obj)
-            obj.id = id_
+        else:
+            id_ = chooser.chooseName(id_, obj)
+        obj.id = id_
         new_id = container._setObject(id_, obj)
         # _setObject triggers ObjectAddedEvent which can end up triggering a
         # content rule to move the item to a different container. In this case