Improve support for missing_value and default story
#1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sneridagh thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
tiberiuichim
approved these changes
Nov 28, 2021
|
@jenkins-plone-org please run jobs |
|
missing_value is a |
jensens
requested changes
Nov 29, 2021
Co-authored-by: Jens W. Klein <jk@kleinundpartner.at>
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
jensens
approved these changes
Nov 30, 2021
tisto
approved these changes
Nov 30, 2021
This was referenced Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1282 .
Could be a conflictive piece of code, so please triple check this. Tricky thing here is that I guess that
missing_valueis azc3.form/Classic UI thing, and we are transferring those responsibilities to the RESTAPI code here. One could argue that the frontend should take care of that instead than the API.