Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation remote url #1654

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Navigation remote url #1654

wants to merge 5 commits into from

Conversation

iFlameing
Copy link
Member

No description provided.

@mister-roboto
Copy link

@iFlameing thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 8f12ba7
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/648190609b2dac000862d761

@iFlameing iFlameing requested a review from davisagli June 6, 2023 14:43
@@ -146,6 +146,8 @@ def navtree(self):
"description": safe_text(brain.Description),
"review_state": json_compatible(brain.review_state),
"use_view_action_in_listings": brain.portal_type in types_using_view,
"remoteUrl": json_compatible(brain.getRemoteUrl),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iFlameing can you elaborate on your use case? Why do we use "remoteURL" and not "remote_url"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisto This was related to a feature request from our client (ticket 1840) which was closed as requiring too much effort

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 25a3e19
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/65d784ced621c10008720980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants