Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port robot tests #118

Merged
merged 4 commits into from
Oct 18, 2024
Merged

port robot tests #118

merged 4 commits into from
Oct 18, 2024

Conversation

1letter
Copy link
Contributor

@1letter 1letter commented Sep 14, 2024

This is part of plone/Products.CMFPlone#3813

  • update configuring with plone/meta
  • port robot tests

@mister-roboto
Copy link

@1letter thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@1letter
Copy link
Contributor Author

1letter commented Sep 14, 2024

@jenkins-plone-org please run jobs

@1letter 1letter marked this pull request as ready for review September 14, 2024 19:39
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, but I don't know anything about playwright yet.

I have a problem though when I try it locally: bin/test hangs on the second test. That is probably something general, so I will ask in the CMFPlone issue.

@petschki
Copy link
Member

@jenkins-plone-org please run jobs

1 similar comment
@petschki
Copy link
Member

@jenkins-plone-org please run jobs

@1letter 1letter self-assigned this Sep 18, 2024
@petschki
Copy link
Member

@jenkins-plone-org please run jobs

1 similar comment
@1letter
Copy link
Contributor Author

1letter commented Oct 9, 2024

@jenkins-plone-org please run jobs

@petschki
Copy link
Member

The failing test is unrelated to this PR.

@petschki petschki merged commit b4e7d3c into master Oct 18, 2024
13 of 14 checks passed
@petschki petschki deleted the port-robot-tests branch October 18, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants