-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port robot tests #118
port robot tests #118
Conversation
@1letter thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me, but I don't know anything about playwright yet.
I have a problem though when I try it locally: bin/test
hangs on the second test. That is probably something general, so I will ask in the CMFPlone issue.
@jenkins-plone-org please run jobs |
1 similar comment
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
1 similar comment
@jenkins-plone-org please run jobs |
The failing test is unrelated to this PR. |
This is part of plone/Products.CMFPlone#3813