Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mockup updates #239

Merged
merged 4 commits into from
Aug 9, 2022
Merged

Mockup updates #239

merged 4 commits into from
Aug 9, 2022

Conversation

petschki
Copy link
Member

@petschki petschki commented Jul 27, 2022

needs plone/plone.schemaeditor#92 ... Jenkins parameters:

https://github.com/plone/plone.schemaeditor/pull/92
https://github.com/plone/plone.staticresources/pull/239

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

1 similar comment
@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki petschki mentioned this pull request Aug 3, 2022
@frapell
Copy link
Member

frapell commented Aug 3, 2022

@jenkins-plone-org please run jobs

@petschki petschki marked this pull request as ready for review August 9, 2022 12:27
@mauritsvanrees
Copy link
Member

Oops, I should have merged this together with plone/plone.schemaeditor#92. Doing so now.

@mauritsvanrees mauritsvanrees merged commit 3050402 into master Aug 9, 2022
@mauritsvanrees mauritsvanrees deleted the mockup-updates branch August 9, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants