Code cleanup, add 'volto.blocks' behavior to Plone Site GS types info… #43
Conversation
…. Remove 'Collection' from types in GS. Remove 'plone.richtext' behavior from Plone Site, Document, News Item, Events.
|
@sneridagh thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@sneridagh I would prefer to keep things working for both versions, if that is possible with reasonable effort. Maintaining multiple branches of multiple packages (plone.volto, plone.restapi, Volto) will not end up well, we saw this in the past (p.a.contenttypes & plone.app.event, plone.app.discussion & dexterity). Plone 5.2 won't go away anytime soon. |
|
@sneridagh zcml condition won't work for gs. A separate profile for Plone 6 seems overkill but might be the only option. What if we register the behavior via Python code and make it conditional? |
|
I agree, let's keep them compatible although it's ugly. It can be done programmatically, of course. I'll prepare it. |
|
@jenkins-plone-org please run jobs |
|
@sneridagh can you resolve the conflict? I guess this should go into the first 4.0.0a1 as well, right? |
|
@tisto Yep |
* main: Remove c.folderishtypes dependency. (#36)
|
@tisto Done! Take a final look before merging. |
|
@jenkins-plone-org please run jobs |
|
@sneridagh LGTM! Feel free to hit the merge button once Jenkins is happy. |
|
@jenkins-plone-org please run jobs |
…. Remove 'Collection' from types in GS. Remove 'plone.richtext' behavior from Plone Site, Document, News Item, Events.