Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Print Stylesheet and Remove Outdated References #386

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Harshit457
Copy link

This pull request refactors the print.scss file to modernize the print styles, improve readability, and remove reliance on outdated or broken external references. Key updates include:

  1. Replaced the $black variable with the standard #000 for consistency.
  2. Updated the background property to none for better clarity.
  3. Enforced hiding of unnecessary elements using display: none and visibility: hidden.
  4. Cleaned up the code for better maintainability by removing redundant declarations.
    These changes ensure the print stylesheet remains functional and easier to maintain without external dependencies.

@mister-roboto
Copy link

@Harshit457 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

If you have already signed the agreement, please allow a week for your agreement to be processed.
Once it is processed, you will receive an email invitation to join the plone GitHub organization as a Contributor.

If after a week you have not received an invitation, then please contact agreements@plone.org.

@mister-roboto
Copy link

@Harshit457 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants