-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating Nuclia Widget #792
base: nuclia
Are you sure you want to change the base?
Conversation
This reverts commit b4533ea.
Removed run on requirements-initial.txt
…o nuclia_widget
…o nuclia_widget
…o nuclia_widget
…o nuclia_widget
Here's that git command from Volto that builds only when docs change: https://github.com/plone/volto/blob/master/netlify.toml#L5 |
git config --global user.email github-actions@github.com | ||
git add . | ||
git commit -m "Nuclia Sync: Updated docs" --allow-empty | ||
git push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So everytime there is a commit on main, we run the job, which makes a commit on main.
It looks like an infinite loop :)
Maybe the job should have a condition like if the last changes are only about our 2 generated json files, we stop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebrehault I have put the check for nuclia_sync.json
only. This should work, right?
Final items to work on:
|
# Conflicts: # docs/_templates/components/search-field.html
I've just updated this branch. I tried to get it to work with Sphinx 8.1.2, but had no luck in local development. I have no idea what to do to get it to work. @justdaksh I know it's been a long time, and I understand if you've moved on. Is this something you would like to work on? Also pinging @ebrehault to discuss. |
Hi @stevepiercy ! |
# Conflicts: # requirements.txt
@ebrehault I updated again with the Plone Sphinx Theme and recent merges to I could post the JavaScript console with its 10 errors, but nothing is obvious to me, so I reckon it goes deeper. |
@stevepiercy I have pushed a fix, the widget is now displayed as expected. |
…ed div to prevent overlap with preceding text
@ebrehault thanks for the assist. It works for me now. I restarted styling things, too. Looking at the search results, I see a lot of MyST markup in the results. This is not good. I was checking out the docs for a better option, and found Index a full website. It looks like I can tell Nuclia to index only the content in the CSS selector If it turns out to be better to index HTML, then we can add a CI step to build the site first. Please let me know your thoughts. Thank you! |
Indexing MyST or HTML will make no difference in terms of quality of the search results (unless the HTML contains side contents like the navigation menu, the footer, etc., that might produce unwanted matches). We have 3 possibilities:
|
|
Nuclia does process local HTML files, but then we do not have the CSS selector option to narrow down to a part of the page, so we need to do that manually. |
hey @stevepiercy, apologies for the delay I was out of town for two weeks and will be back home the day after tomorrow. I'll get to this as soon as I reach back. |
Hi @justdaksh, I'm glad you're still around! I would like to go with Option 2, build HTML then index content. I will be pushing a few commits to this branch, to bring it up to date with the latest Plone Sphinx Theme. Ping me on Discord, if you want to chat about anything. |
CC: @stevepiercy
Here is a draft for Nuclia widget integration into training.
Some of the issues to be solved:
Pull request preview URL:
https://plone-training--792.org.readthedocs.build/