Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shifting from .md to html in Nuclia #881

Open
wants to merge 3 commits into
base: nuclia_widget
Choose a base branch
from
Open

Shifting from .md to html in Nuclia #881

wants to merge 3 commits into from

Conversation

justdaksh
Copy link

@justdaksh justdaksh commented Nov 20, 2024 •
edited by github-actions bot
Loading

@stevepiercy Nuclia Knowledge Base has now been indexed with HTML

Issues

  • Some result's URL appear to be broken
  • Bug in CI workflow
  • Breadcrumbs not visible in search results

📚 Documentation preview 📚: https://plone6--881.org.readthedocs.build/

@justdaksh justdaksh changed the title Shifting from .md to html injestion Shifting from .md to html in Nuclia Nov 20, 2024
stevepiercy
stevepiercy reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions. Otherwise this looks good.

.github/workflows/nuclia_sync.yml Outdated Show resolved Hide resolved
upload.py


def create_url(origin_url, url_path):
return f"{origin_url.rstrip('/')}/{url_path}"

def transform_path_to_url(path, base_url):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should do a transformation. Some trainings follow the _ convention, others -. Is there a reason to do a transformation?

@justdaksh
Copy link
Author

Ahh yes, transform_path_to_url function just merges normalize and create URL. I forgot to remove them but I have fixed that now.
when creating URL for volto_customization training we need - instead of _ so the function just does that only.
so we get https://training.plone.org/volto-customization/index.html
instead of https://training.plone.org/volto_customization/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justdaksh @stevepiercy