Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to Vite website #6366

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fix links to Vite website #6366

merged 2 commits into from
Oct 3, 2024

Conversation

stevepiercy
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 5727d40
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66fe335f59d0c20008ce68cf

@stevepiercy
Copy link
Collaborator Author

I put a changelog entry in packages/volto/news, because our docs don't say where to put changes to apps. See https://6.docs.plone.org/contributing/index.html#change-log-entry.

I can update the docs in a separate PR, but I need to know the correct location.

Also one of the changelog checks passed because we don't check apps.

@sneridagh
Copy link
Member

@stevepiercy wut! they should have changed it yesterday, I've been cheking docs the last weeks in vitejs.dev. Today it's their conf, I guess they changed it to have it by then.

@sneridagh sneridagh merged commit dc787b1 into main Oct 3, 2024
70 checks passed
@sneridagh sneridagh deleted the linkcheck-2024-10-02 branch October 3, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants