Add a pull request template as a checklist before submitting a PR #6365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
stevepiercy
requested review from
davisagli,
ichim-david,
polyester,
esteele and
sneridagh
|
See #6366 for a fix for the failing readme linkcheck. |
ichim-david
approved these changes
Oct 3, 2024
sneridagh
approved these changes
Oct 3, 2024
|
I previously thought that we might include something that could potentially run afoul of Plone community guidelines, but I omitted those items because the incidents of "class assignments" have died down to almost nothing. And here we are in Hacktoberfest 🤮! I attribute that to our documented Contributing guidelines. I think they moved on to the Collective 🤣. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an opening a pull request, this checklist will populate the description to direct developers to resources so we don't have to nag them. Everyone wins!
Closes #6223.