Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rule for ESlint to detect missing key property in iterators. #6387

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

sneridagh
Copy link
Member


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 69f05f2
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6706784ad1f2620008630001

docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM!

@sneridagh sneridagh merged commit 0dcfb58 into main Oct 9, 2024
71 checks passed
@sneridagh sneridagh deleted the addESlintRuleMissingJSXkeyDetection branch October 9, 2024 13:31
sneridagh added a commit that referenced this pull request Oct 14, 2024
* main: (185 commits)
  Release @plone/components 2.0.0-alpha.15
  [components] Fix Select component logic to support `items` use case (#6405)
  Fix clean make command (#6403)
  Release 18.0.0-alpha.46
  Release @plone/components 2.0.0-alpha.14
  Add missing export for new components (#6391)
  Revert "Fix block chooser search is not focusable when clicked on add button" (#6390)
  Replace unhelpful words with helpful ones (#6386)
  Added missing improvement to the build-deps Makefile command (#6383)
  Added rule for ESlint to detect missing key property in iterators. (#6387)
  Fix syntax of `html_meta` under `myst` field. (#6385)
  Release 18.0.0-alpha.45
  Release @plone/components 2.0.0-alpha.13
  Release @plone/types 1.0.0-alpha.20
  Add chapter: theming a base theme (#6328)
  Upgrade vite to latest (#6373)
  Porting a few minor fixes upstream (#6382)
  Added missing arg for `buildStyleClassNamesExtenders` (#6381)
  Remove pin on Vale, and upgrade to v3.x configuration (#6376)
  Change formatting from blob of text to definition list. (#6378)
  ...
sneridagh added a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants