-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chapter: theming a base theme #6328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
stevepiercy
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @MrTango! I made my review as a bunch of edits, and pushed. Would you please double-check my work?
I'd like one more review from another @plone/volto-team member for accuracy. Then let's merge.
sneridagh
approved these changes
Oct 3, 2024
davisagli
approved these changes
Oct 3, 2024
sneridagh
added a commit
that referenced
this pull request
Oct 14, 2024
* main: (185 commits) Release @plone/components 2.0.0-alpha.15 [components] Fix Select component logic to support `items` use case (#6405) Fix clean make command (#6403) Release 18.0.0-alpha.46 Release @plone/components 2.0.0-alpha.14 Add missing export for new components (#6391) Revert "Fix block chooser search is not focusable when clicked on add button" (#6390) Replace unhelpful words with helpful ones (#6386) Added missing improvement to the build-deps Makefile command (#6383) Added rule for ESlint to detect missing key property in iterators. (#6387) Fix syntax of `html_meta` under `myst` field. (#6385) Release 18.0.0-alpha.45 Release @plone/components 2.0.0-alpha.13 Release @plone/types 1.0.0-alpha.20 Add chapter: theming a base theme (#6328) Upgrade vite to latest (#6373) Porting a few minor fixes upstream (#6382) Added missing arg for `buildStyleClassNamesExtenders` (#6381) Remove pin on Vale, and upgrade to v3.x configuration (#6376) Change formatting from blob of text to definition list. (#6378) ...
sneridagh
pushed a commit
that referenced
this pull request
Oct 18, 2024
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explains the simple use case of using a base theme like the
Volto Light Theme
and customize it via SCSS and CSS in a Volto addon.📚 Documentation preview 📚: https://volto--6328.org.readthedocs.build/