Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useEffect from LinkView to ensure the logic runs before render #6464

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JeffersonBledsoe
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe commented Nov 4, 2024


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #6463

Screen.Recording.2024-11-04.at.14.03.10.mov

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit fe08438
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6728d6954a549e000807cc70

@JeffersonBledsoe JeffersonBledsoe marked this pull request as ready for review November 4, 2024 14:15
@JeffersonBledsoe JeffersonBledsoe requested a review from a team November 4, 2024 14:24
@ichim-david
Copy link
Member

@JeffersonBledsoe Add also the video with the after behavior when trying the same actions.

@JeffersonBledsoe
Copy link
Member Author

JeffersonBledsoe commented Nov 4, 2024

@ichim-david The after video is the one here, the before video is in the linked issue

}
}, [content, history, token]);
if (__SERVER__ && !token && content.remoteUrl) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffersonBledsoe Are you sure this will not raise an error on SSR 🤔 ?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link content type flashes the logged in page when navigating client-side
3 participants