Scroll to top only if the location pathname changes #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiberiuichim
approved these changes
Aug 24, 2021
avoinea
approved these changes
Aug 31, 2021
|
The discussion at team meeting was to only ignore the hash. So the location.pathname + location.search should be used as criteria. Also document this behavior (scroll to top happens if pathname or search parameters change) in some Volto documentation |
|
@kreafox See above |
tiberiuichim
approved these changes
Aug 31, 2021
sneridagh
approved these changes
Sep 1, 2021
sneridagh
added a commit
that referenced
this pull request
Sep 1, 2021
* master: Back to development Release 13.13.0 Prepare for release Showing version in History view (#2634) Fix SearchWidget required pathname (#2646) Fix content tags modal (#2641) Cut/Copy blocks: fixed cut/copy unselected blocks. (#2638) Fix QueryWidget styling (#2636) Bump tar from 6.1.6 to 6.1.11 (#2648) Bump tar from 6.1.8 to 6.1.11 in /packages/generator-volto (#2647) Scroll to top only if the location pathname changes (#2635) Disabled all the other configuration options when user did not choose… (#2629) Update pt_BR translation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.