Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions storybook test #5049

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Actions storybook test #5049

merged 6 commits into from
Aug 14, 2024

Conversation

Tishasoumya-02
Copy link
Contributor

#4460.
Doubt in this test .

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit eb95944
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/651c387befc24b0008b53fcc
😎 Deploy Preview https://deploy-preview-5049--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Aug 1, 2023

Passing run #6701 ↗︎

0 553 20 0 Flakiness 0

Details:

/news
Project: Volto Commit: 7ac9e7bf2d
Status: Passed Duration: 12:51 💡
Started: Aug 1, 2023 2:49 PM Ended: Aug 1, 2023 3:02 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@tiberiuichim
Copy link
Contributor

Cool, too bad the Actions component is not reusable

Copy link
Contributor

@tiberiuichim tiberiuichim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an Internal component, rename the story to "Actions menu"

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 3f16a4c
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66bb3471d6211f0009b1281a

@stevepiercy
Copy link
Collaborator

@Tishasoumya-02 if you update this branch from main, many of the failing GitHub workflows should pass, as actions/upload-artifact@v1 was updated on main. I think you have permission, and should see the Update branch button.

@davisagli davisagli merged commit cbc1cb3 into main Aug 14, 2024
70 checks passed
@davisagli davisagli deleted the actions-storybook branch August 14, 2024 04:35
@Tishasoumya-02 Tishasoumya-02 restored the actions-storybook branch August 20, 2024 13:53
@Tishasoumya-02
Copy link
Contributor Author

@davisagli , I realized that the actions storybook test is in the wrong directory right now. Should I open a new PR to correct this or the changes can be reverted?

@davisagli
Copy link
Member

@Tishasoumya-02 It's probably easiest to fix it in a new PR.

@wesleybl
Copy link
Member

@Tishasoumya-02 why do we have a src folder in the project root? The packages folder is usually used.

@stevepiercy
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants