-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks Layout Navigator #5642
Blocks Layout Navigator #5642
Conversation
✅ Deploy Preview for plone-components canceled.
|
✅ Deploy Preview for volto canceled.
|
May I suggest the following UI changes:
When hovering over the text, I would get a floating thumbnail of the image. For the slate text, the preview component could be like:
When hovering over the text, I can get a floating preview of the entire text block. |
@tiberiuichim no worries, still under development, I just updated it. There are a couple of things to polish and others that do not work well. The UI should be far more fancy, for sure. Now it's debugging mode :) |
8378cec
to
5a66a0e
Compare
af56e9c
to
f3a330f
Compare
@sneridagh I would be inclined to have it more hidden away. Instead of a tab, it could be inside the block tab at the top as a rolldown. So when collapsed it shows the indent and identity of the current block. uncollapsing it lets you see the current block in context of parents and switch to another block. |
@sneridagh I'm not saying to change how it works. It's great and it's an important part of the decoupled editor. |
@robgietema I've end up by commenting out the I cannot see any different behavior by removing it, probably I'm missing an edge case. If it's that so, we have to come back to it, but for now, it's good enough for me not to hold it any more. |
packages/volto/src/components/manage/Blocks/Block/__snapshots__/BlocksForm.test.jsx.snap
Show resolved
Hide resolved
@stevepiercy I would not trust the stats for this on a system that does not work well for editing on mobile. See: https://en.wikipedia.org/wiki/Survivorship_bias |
@davisagli drag and drop on a tiny mobile screen is difficult to use, if not impossible. It's a matter of choosing the right tool for the job. You can choose not to trust the data and insist that DnD be fixed, but then you would spend significant effort on something that is extremely difficult to implement. |
Oh sorry, I jumped into the conversation in the middle and wasn't trying to argue against merging this PR. I think the new navigator is an improvement over the status quo for all screen sizes, both in terms of usability (it's hard to drag large blocks currently) and maintainability. |
packages/volto/src/components/manage/Blocks/Block/BlocksForm.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Giulia Ghisini <51911425+giuliaghisini@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sneridagh @robgietema there is no drag handle visible on FF and trying to click and drag within the section where the icon should be doesn't do anything.
The Block is highlighted in the order sidebar and in the main section but no drag ability.
This doesn't happen in Edge where the drag handle shows up and you can drag.
@sneridagh besides the missing functionality altogether on FF there has to be some regression introduced recently as it seems that even on Edge and Safari although I can drag and drop it doesn't change the order, have a look at this screen recording. drag-not-changing.mp4 |
@sneridagh sorry for all of these extra comments, I found out why the drag and drop doesn't work on Edge and Safari, unknown-block.mp4Don't know if you want to try to treat this or simply add a documentation entry that it won't work until those blocks EDIT: the issue on FF remains even if I am on a page without any unknown blocks |
@ichim-david thanks for the report. |
@ichim-david I think I quick fixed the FF problem, please take a look. |
@sneridagh Confirmed working now on FF. Up to you on how you think we should proceed about the unknown block. For me it's enough to have a doc entry that it doesn't work on pages where you have unknown blocks until you remove them. |
* main: (63 commits) Release 18.0.0-alpha.35 Release @plone/types 1.0.0-alpha.16 (fix): export getFieldURL from Url.js in helpers (#6100) Improve container detection, `config.settings.containerBlockTypes` is no longer needed (#6099) Support nested directories in public folder add-on sync folders both … (#6098) Release 18.0.0-alpha.34 Add generated new declarations for a34, just in case (#6097) Release @plone/slate 18.0.0-alpha.13 Release @plone/registry 1.6.0 Release @plone/types 1.0.0-alpha.15 Add support for reading the add-ons `tsconfig.json` paths (#6096) Fixes #6046 pass proper defaults to align and size fields of Image block (#6093) bug fix. relations control panel. Restrict eglible relation targets a… (#6092) Fix Uncaught RangeError: date value is not finite in DateTimeFormat.format (#6088) Add optional `token` parameter to ploneClient initialization (#6077) Blocks Layout Navigator (#5642) Fix internalUrl Widget to Reflect Prop Changes via onChangeBlock (#6036) [types] Improve styleClassNameExtenders types, Icon component JSDoc t… (#6095) Fix link in pop-up RelationsMatrix.jsx (#6085) Fix deselecting lists. (#6080) ...
* main: (42 commits) Release 18.0.0-alpha.35 Release @plone/types 1.0.0-alpha.16 (fix): export getFieldURL from Url.js in helpers (plone#6100) Improve container detection, `config.settings.containerBlockTypes` is no longer needed (plone#6099) Support nested directories in public folder add-on sync folders both … (plone#6098) Release 18.0.0-alpha.34 Add generated new declarations for a34, just in case (plone#6097) Release @plone/slate 18.0.0-alpha.13 Release @plone/registry 1.6.0 Release @plone/types 1.0.0-alpha.15 Add support for reading the add-ons `tsconfig.json` paths (plone#6096) Fixes plone#6046 pass proper defaults to align and size fields of Image block (plone#6093) bug fix. relations control panel. Restrict eglible relation targets a… (plone#6092) Fix Uncaught RangeError: date value is not finite in DateTimeFormat.format (plone#6088) Add optional `token` parameter to ploneClient initialization (plone#6077) Blocks Layout Navigator (plone#5642) Fix internalUrl Widget to Reflect Prop Changes via onChangeBlock (plone#6036) [types] Improve styleClassNameExtenders types, Icon component JSDoc t… (plone#6095) Fix link in pop-up RelationsMatrix.jsx (plone#6085) Fix deselecting lists. (plone#6080) ...
* main: (31 commits) Release 18.0.0-alpha.35 Release @plone/types 1.0.0-alpha.16 (fix): export getFieldURL from Url.js in helpers (#6100) Improve container detection, `config.settings.containerBlockTypes` is no longer needed (#6099) Support nested directories in public folder add-on sync folders both … (#6098) Release 18.0.0-alpha.34 Add generated new declarations for a34, just in case (#6097) Release @plone/slate 18.0.0-alpha.13 Release @plone/registry 1.6.0 Release @plone/types 1.0.0-alpha.15 Add support for reading the add-ons `tsconfig.json` paths (#6096) Fixes #6046 pass proper defaults to align and size fields of Image block (#6093) bug fix. relations control panel. Restrict eglible relation targets a… (#6092) Fix Uncaught RangeError: date value is not finite in DateTimeFormat.format (#6088) Add optional `token` parameter to ploneClient initialization (#6077) Blocks Layout Navigator (#5642) Fix internalUrl Widget to Reflect Prop Changes via onChangeBlock (#6036) [types] Improve styleClassNameExtenders types, Icon component JSDoc t… (#6095) Fix link in pop-up RelationsMatrix.jsx (#6085) Fix deselecting lists. (#6080) ...
Supersedes: #4745
Screen.Recording.2024-06-10.at.09.45.32.mov