Empty GridBlocks will not be rendered in 'View' #6280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
davisagli
reviewed
Sep 9, 2024
sneridagh
added a commit
that referenced
this pull request
Sep 14, 2024
* main: (97 commits) Release 18.0.0-alpha.43 Release @plone/slate 18.0.0-alpha.18 Release @plone/client 1.0.0-alpha.17 Added a notice in the upgrade guide for CookiePlone as the recommended way for generating projects and add-on boilerplate (#6286) Fix typo in Changelog for #6285 (#6287) Update to Volto 6.0.13 (#6285) Fix order component (#6284) Remove dangling `.only` in Cypress test (#6282) Empty GridBlocks will not be rendered in 'View' (#6280) Refactor Content upload modal (#5047) Passes the `user` to the `restricted` function of the block settings (#6271) Refactored SelectMetadataField.jsx to functional component (#5570) Remove "Generate tabs for items other than folders" field from navigation control panel (#6278) Refactor DatetimeWidget (#6213) Added make i18n to volto (#6274) Place the actions-storybook in correct folder (#6275) Refactor ReferenceWidget (#5093) Fix error in SortOn component when there is no sort selected. (#6273) When user changes location, set the userSession.token value based on cookie (#6079) Trivial MyST syntax enhancement ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6279
This can be a single line fix:
volto/packages/volto/src/components/manage/Blocks/Grid/View.jsx
Line 10 in 7690677
adding this check just before the above mentioned line will fix this
then this won't render any Grid block since its empty so it makes sense too, but yeah it remains in the formData so going into edit again will open up the TemplateChooser again.