onFocus handle to focus tabbed blocks #6314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
Wagner3UB
changed the title
Wagner3UB
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus issue when entering a block using the Tab key has been fixed. Now, the onFocus function works similarly to the onClick function, giving focus to the block and activating the visible border and functional buttons (drag, delete, and add block).
To reproduce this issue:
1-Enter edit mode
2-Press Tab to move from the title to the first block
3-Go back to the title by pressing the Up Arrow key
4-Press Tab again
-Without this fix, the focus would not appear on the block.
P.S.: At this point, the focus is trapped and those buttons are not accessible yet, we can change block pressing arrow up/down, but those buttons aren't focusable. This will be fixed soon (I hope).