-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browserlist #6455
Update browserlist #6455
Conversation
✅ Deploy Preview for plone-components canceled.
|
… :( . Adding a workaround
https://www.npmjs.com/package/browserlist says use https://github.com/browserslist/browserslist. browserslist. Should we use GitHub directly instead of npmjs.com? Also https://6.docs.plone.org/volto/contributing/language-features.html#browser-compatibility should be updated, if you change that requirement. There's also another typo. |
@@ -27,7 +27,8 @@ | |||
"lockhook": "node packages/scripts/lockhook.js", | |||
"prepare": "husky", | |||
"husky:uninstall": "husky uninstall", | |||
"prereleaser": "node packages/scripts/preleaser.js" | |||
"prereleaser": "node packages/scripts/preleaser.js", | |||
"update:browserlist": "pnpm --filter @plone/volto add caniuse-lite && pnpm --filter @plone/volto remove caniuse-lite" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sneridagh Despite removing it in this command, caniuse-lite
ended up in the lockfile. Is that a mistake?
@stevepiercy We are in fact using browserslist, not browserlist. It is misspelled in the title of this PR, the towncrier entry, and a couple places in https://6.docs.plone.org/volto/contributing/language-features.html#browser-compatibility Updating the package doesn't change the rules that we are using it to apply. |
…e commit for it in this PR. See #6455 (comment) and ping @davisagli
* main: (26 commits) Release generate-volto 9.0.0 Changelog Release 18.0.0 Preparations for 18.0.0 final release (#6281) Release @plone/slate 18.0.0 Changelog Release @plone/components 2.0.0 Changelog Release @plone/registry 2.0.0 Changelog Release @plone/types 1.0.0 Changelog Release 18.0.0-alpha.49 Update browserlist (#6455) Update Romanian translation (#6454) Update pt_BR translation (#6453) Release 18.0.0-alpha.48 Fix declaration emits for wrong JSDocs Release @plone/slate 18.0.0-alpha.20 Release @plone/types 1.0.0-alpha.22 ...
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #