Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browserlist #6455

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Update browserlist #6455

merged 3 commits into from
Oct 31, 2024

Conversation

sneridagh
Copy link
Member


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 67a5862
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6723a81e2c135c00088b51c4

@sneridagh sneridagh merged commit f575593 into main Oct 31, 2024
68 checks passed
@sneridagh sneridagh deleted the updatebl branch October 31, 2024 16:04
sneridagh added a commit that referenced this pull request Oct 31, 2024
* main:
  Update browserlist (#6455)
  Update Romanian translation (#6454)
  Update pt_BR translation (#6453)
  Release 18.0.0-alpha.48
  Fix declaration emits for wrong JSDocs
  Release @plone/slate 18.0.0-alpha.20
  Release @plone/types 1.0.0-alpha.22
@stevepiercy
Copy link
Collaborator

https://www.npmjs.com/package/browserlist says use https://github.com/browserslist/browserslist. browserslist. Should we use GitHub directly instead of npmjs.com?

Also https://6.docs.plone.org/volto/contributing/language-features.html#browser-compatibility should be updated, if you change that requirement. There's also another typo.

@@ -27,7 +27,8 @@
"lockhook": "node packages/scripts/lockhook.js",
"prepare": "husky",
"husky:uninstall": "husky uninstall",
"prereleaser": "node packages/scripts/preleaser.js"
"prereleaser": "node packages/scripts/preleaser.js",
"update:browserlist": "pnpm --filter @plone/volto add caniuse-lite && pnpm --filter @plone/volto remove caniuse-lite"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneridagh Despite removing it in this command, caniuse-lite ended up in the lockfile. Is that a mistake?

@davisagli
Copy link
Member

davisagli commented Oct 31, 2024

@stevepiercy We are in fact using browserslist, not browserlist. It is misspelled in the title of this PR, the towncrier entry, and a couple places in https://6.docs.plone.org/volto/contributing/language-features.html#browser-compatibility

Updating the package doesn't change the rules that we are using it to apply.

stevepiercy added a commit that referenced this pull request Nov 1, 2024
@stevepiercy
Copy link
Collaborator

Addressed in 528ef97 as part of #6397

sneridagh added a commit that referenced this pull request Nov 1, 2024
* main: (26 commits)
  Release generate-volto 9.0.0
  Changelog
  Release 18.0.0
  Preparations for 18.0.0 final release (#6281)
  Release @plone/slate 18.0.0
  Changelog
  Release @plone/components 2.0.0
  Changelog
  Release @plone/registry 2.0.0
  Changelog
  Release @plone/types 1.0.0
  Changelog
  Release 18.0.0-alpha.49
  Update browserlist (#6455)
  Update Romanian translation (#6454)
  Update pt_BR translation (#6453)
  Release 18.0.0-alpha.48
  Fix declaration emits for wrong JSDocs
  Release @plone/slate 18.0.0-alpha.20
  Release @plone/types 1.0.0-alpha.22
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants