Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use component registry to make the body of the LinkView page customisable #6465

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JeffersonBledsoe
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe commented Nov 4, 2024


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 8ac042f
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/672de0d0dac3d6000891ff74

@JeffersonBledsoe JeffersonBledsoe changed the title Use component registry to make the body of the LinkView page customis… Use component registry to make the body of the LinkView page customisable Nov 4, 2024
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me, I have one small suggestion.

packages/volto/src/components/theme/View/LinkView.jsx Outdated Show resolved Hide resolved
@davisagli
Copy link
Member

@JeffersonBledsoe unit tests are failing because the snapshots need to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants