Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue Number-6143 #6484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Harshit-7373
Copy link

When selecting a start datetime, the end datetime should be after the start datetime. #6143.

github - Harshit-7373.


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

When selecting a start datetime, the end datetime should be after the start datetime. plone#6143.

github - Harshit-7373.
@mister-roboto
Copy link

@Harshit-7373 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

If you have already signed the agreement, please allow a week for your agreement to be processed.
Once it is processed, you will receive an email invitation to join the plone GitHub organization as a Contributor.

If after a week you have not received an invitation, then please contact agreements@plone.org.

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 1cdcdbe
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6738addbd6c7d700082bf197

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is not an acceptable solution. This validation should happen on the client side using the existing validation framework that's integrated with the form components in packages/volto. Your solution bypasses most of how Volto works, and only tries to solve this for the experimental vite app.

@Harshit-7373
Copy link
Author

Thank you for the feedback. I understand now that the validation should be handled on the client side using the existing validation framework integrated with the form components in the packages/volto. I’ll make sure to align with Volto’s existing structure and ensure that the solution does not bypass its core functionality. I’ll update my approach accordingly to work seamlessly with the current framework.

Please let me know if you have any further suggestions or if there’s anything else I should consider.

@stevepiercy
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants