Add SSR helper to get resources (images/files) from the server using the API headers #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First iteration Final touches
sneridagh
force-pushed
the
fixauthimagesrequests
branch
from
0fed529
to
b8e57cb
Compare
|
I wake up this morning with this idea... I had to implement it right away. After this, I really think that SSR is the hidden secret weapon of Volto... The only "issue" that I see is that we force the SSR server to serve all the images. Do you think that we shouldn't do it for anonymous sessions? It won't be difficult I guess... Also, if someone requests the image in Volto and it's private, it redirects to Plone... something that we can also polish I guess. |
sneridagh
changed the title
bloodbare
approved these changes
Feb 27, 2019
This was referenced Feb 28, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.