[WIP] - fix date widget #709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
There are tons of React widget options. We used the AirBnB datepicker in some projects and had good experience with it. New events should have the date set to now. I guess this is something the Volto frontend could provide. |
|
@cekk @pnicolli what's the status here? There is also another approach by @nzambello ? |
|
@sneridagh I know @nzambello had something going on, but I'm actually not well informed on that. On the other hand, we will for sure need to make sure events are fully working in the next few weeks, so we definitely have this on the radar. We'll let you know. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #632
The problem was on date format: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local#Setting_timezones
We receive a date like 2019-04-17T10:00:00+00:00 with also timezone info, but datetime-local html field doesn't like timezone anymore.
I needed to convert UTC datetime into local datetime and pass the value without timezone to the input field.
And on change i re-convert the date into UTC for plone.restapi.
I haven't touched the widget to use something better because i don't know what's your plans about date widgets. There are some nice plugins for React.
One other thing: right now a new event has empty dates. In Plone these dates are set as now.
Is it a good idea provide now as default when invoking this widget for event fields?
Also adding a button that sets the date as now like in Plone.