-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Dash in Flask #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchen39 one comment, also please let us know when the blog is ready too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG overall one small change
I think it would be better to organize the code files into 2 subfolders: |
@neelasha23 @bryannho Based on Neelasha's suggestion, I will organize my code into 2 folders:
I will also put the images in a separate folder but leave the README in the main folder To upload, the user can zip the content in the folder or directly deploy the app in the command line. The user won't need to I will update the content in my blog as well. Let me know if this works! |
I realized earlier that I had misunderstood the fundamental difference between the two approaches:
I have made the changes to the project structure and rewrote my README. Please check the web apps: middleware approach and the hosting approach. I will also reflect on these changes in my blog. Let me know if you have other questions or comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG overall, I think the change makes a lot of sense. Small comments
@bchen39 is this ready for review? |
Please also check the links to my test applications, using app context and middleware
Closes ploomber.io#198
📚 Documentation preview 📚: https://ploomber-doc--263.org.readthedocs.build/en/263/