added issue numbers

ploomber · May 31, 2023 · 20e2420 · 20e2420
1 parent 48b43ea
commit 20e2420
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/sql/magic.py b/src/sql/magic.py
@@ -483,7 +483,7 @@ def interactive_execute_wrapper(**kwargs):
                     err = exceptions.UsageError(detailed_msg)
                     raise err
                     # TODO: move to error_messages.py
-                    # Added here due to circular dependency issue
+                    # Added here due to circular dependency issue (#545)
                 elif "no such table" in str(e):
                     tables = query_util.extract_tables_from_query(command.sql)
                     for table in tables:

diff --git a/src/sql/magic_cmd.py b/src/sql/magic_cmd.py
@@ -34,7 +34,7 @@ def error(self, message):
         raise exceptions.UsageError(message)
 
 
-# Added here due to circular dependencies
+# Added here due to circular dependencies (#545)
 from sql.sqlcmd import sqlcmd_snippets  # noqa
 
 

diff --git a/src/sql/query_util.py b/src/sql/query_util.py
@@ -24,5 +24,6 @@ def extract_tables_from_query(query):
         # TODO : Instead of returning [] replace with call to
         # error_messages.py::parse_sqlglot_error. Currently this
         # is not possible because of an exception raised in test
-        # fixtures.
+        # fixtures. (#546). This function can also be moved to util.py
+        # after #545 is resolved.
         return []