check ex

ploomber · Jan 24, 2024 · 4d16948 · 4d16948
1 parent bdf7c46
commit 4d16948
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -76,7 +76,6 @@ jobs:
     needs: [preliminary]
     if: needs.preliminary.outputs.check_doc_modified == 'failure'
     uses: ./.github/workflows/ci-integration-db-sqlalchemy-v1.yaml
-    secrets: inherit
 
   integration-test-non-live:
     needs: [preliminary]

diff --git a/src/sql/_testing.py b/src/sql/_testing.py
@@ -510,18 +510,21 @@ def clickhouse(is_bypass_init=False, print_credentials=False):
         yield curr
     except docker.errors.NotFound:
         print("Creating new container: clickhouse")
-        with new_container(
-            new_container_name=db_config["docker_ct"]["name"],
-            image_name=db_config["docker_ct"]["image"],
-            ports=db_config["docker_ct"]["ports"],
-            environment={
-                "CLICKHOUSE_USER": db_config["username"],
-                "CLICKHOUSE_PASSWORD": db_config["password"],
-                "CLICKHOUSE_DB": db_config["database"],
-            },
-            ready_test=lambda: database_ready(database="clickhouse"),
-        ) as container:
-            yield container
+        try:
+            with new_container(
+                new_container_name=db_config["docker_ct"]["name"],
+                image_name=db_config["docker_ct"]["image"],
+                ports=db_config["docker_ct"]["ports"],
+                environment={
+                    "CLICKHOUSE_USER": db_config["username"],
+                    "CLICKHOUSE_PASSWORD": db_config["password"],
+                    "CLICKHOUSE_DB": db_config["database"],
+                },
+                ready_test=lambda: database_ready(database="clickhouse"),
+            ) as container:
+                yield container
+        except Exception as e:
+            print(str(e))
 
 
 def main():