install sqlalchemy

ploomber · Jan 24, 2024 · d3dad85 · d3dad85
1 parent 3ac5c44
commit d3dad85
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 16 deletions.
diff --git a/noxfile.py b/noxfile.py
@@ -160,6 +160,8 @@ def test_integration_sqlachemy_v1(session):
 
     # tests
     _install(session, integration=True)
+    session.install("sqlalchemy<2")
+    _check_sqlalchemy(session, version=1)
     session.install(
         "clickhouse-sqlalchemy",
     )
@@ -183,6 +185,6 @@ def test_integration(session):
         "pytest",
         "src/tests/integration",
         "-k",
-        "not (snowflake or redshift)",
+        "not (snowflake or redshift or clickhouse)",
         "-v",
     )
diff --git a/src/sql/_testing.py b/src/sql/_testing.py
@@ -510,21 +510,18 @@ def clickhouse(is_bypass_init=False, print_credentials=False):
         yield curr
     except docker.errors.NotFound:
         print("Creating new container: clickhouse")
-        try:
-            with new_container(
-                new_container_name=db_config["docker_ct"]["name"],
-                image_name=db_config["docker_ct"]["image"],
-                ports=db_config["docker_ct"]["ports"],
-                environment={
-                    "CLICKHOUSE_USER": db_config["username"],
-                    "CLICKHOUSE_PASSWORD": db_config["password"],
-                    "CLICKHOUSE_DB": db_config["database"],
-                },
-                ready_test=lambda: database_ready(database="clickhouse"),
-            ) as container:
-                yield container
-        except Exception as e:
-            print(str(e))
+        with new_container(
+            new_container_name=db_config["docker_ct"]["name"],
+            image_name=db_config["docker_ct"]["image"],
+            ports=db_config["docker_ct"]["ports"],
+            environment={
+                "CLICKHOUSE_USER": db_config["username"],
+                "CLICKHOUSE_PASSWORD": db_config["password"],
+                "CLICKHOUSE_DB": db_config["database"],
+            },
+            ready_test=lambda: database_ready(database="clickhouse"),
+        ) as container:
+            yield container
 
 
 def main():